Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default account names #34

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Change default account names #34

merged 1 commit into from
Sep 5, 2023

Conversation

0xmgb
Copy link
Contributor

@0xmgb 0xmgb commented Aug 30, 2023

Went from dog-themed to ocean/boat-themed.

"Nautilus" - Named after the submarine in Jules Verne's "Twenty Thousand Leagues Under the Sea."
"Poseidon" - The Greek god of the sea.
"Compass" - An essential tool for navigation.
"Calypso" - A sea nymph in Greek mythology, also the name of Jacques Cousteau's research vessel.
"Marina" - A place where boats are docked.
"Siren" - Mythical creatures that lured sailors to their doom, but also a term used in modern boating for warning devices.
"Endeavour" - Named after Captain Cook's research vessel.
"Yawl" - A type of two-masted sailing craft.

Copy link
Contributor

@Juuddi Juuddi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@Djadih Djadih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Yawl" is slightly better than "Foz"
Overall an improvement, LGTM

Edit: Make sure to sign the commits
git reset HEAD~
stage/add
git commit -S -m "msg"

Copy link
Collaborator

@jdowning100 jdowning100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@wizeguyy wizeguyy merged commit 7b0d86a into PelagusWallet:main Sep 5, 2023
4 of 6 checks passed
rileystephens28 pushed a commit that referenced this pull request Jul 25, 2024
…roviders (#34)

Co-authored-by: Artem Burakov <artem@burakov.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants