Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]: changed typo and removed native_reference #756

Open
wants to merge 1 commit into
base: enh/custom-template
Choose a base branch
from

Conversation

chiuhoward
Copy link

Changes proposed in this pull request

Changing what @richford and I think is a typo - native_template_brain_file to native_template_mask_file to be consistent with the other usage of this variable. We also removed native_reference as we did not see the variable being used elsewhere in the code.

  1. Was native_reference a placeholder for WIP? If so, could you point us to where we should use it? We'll be happy to finish it.
  2. Could you also suggest a simple test that we could write for new native templates?

Documentation that should be reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant