Skip to content

Commit

Permalink
[no ci] Update comment about ".so" suffix
Browse files Browse the repository at this point in the history
  • Loading branch information
joeycarter committed Nov 14, 2024
1 parent 5b42f56 commit e528fae
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions runtime/lib/backend/openqasm/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ find_package(nanobind CONFIG REQUIRED)
nanobind_add_module(openqasm_python_module STABLE_ABI openqasm_python_module.cpp)

# Use a consistant suffix ".so" rather than, e.g. ".abi3.so" (when using the Stable ABI) or
# ".cpython-3xx-darwin.so". This ensures we can locate it when calling `dlopen(OPENQASM_PY)` in
# runtime/lib/backend/openqasm/OpenQasmRunner.hpp.
# ".cpython-3xx-darwin.so". Doing so simplifies the process to locate it when calling
# `dlopen(OPENQASM_PY)` in runtime/lib/backend/openqasm/OpenQasmRunner.hpp.
set_target_properties(openqasm_python_module PROPERTIES SUFFIX ".so")

add_library(rtd_openqasm SHARED OpenQasmDevice.cpp)
Expand Down
4 changes: 2 additions & 2 deletions runtime/lib/registry/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ set(REGISTRY_SRC_FILES
nanobind_add_module(catalyst_callback_registry STABLE_ABI ${REGISTRY_SRC_FILES})

# Use a consistant suffix ".so" rather than, e.g. ".abi3.so" (when using the Stable ABI) or
# ".cpython-3xx-darwin.so". This ensures we can locate it when calling `dlopen(LIBREGISTRY)` in
# runtime/lib/capi/RuntimeCAPI.cpp.
# ".cpython-3xx-darwin.so". Doing so simplifies the process to locate it when calling
# `dlopen(LIBREGISTRY)` in runtime/lib/capi/RuntimeCAPI.cpp.
set_target_properties(catalyst_callback_registry PROPERTIES SUFFIX ".so")

target_include_directories(catalyst_callback_registry PUBLIC ${runtime_includes})
Expand Down

0 comments on commit e528fae

Please sign in to comment.