-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pybind11 modules from Catalyst's core MLIR libs #1187
Open
joeycarter
wants to merge
34
commits into
main
Choose a base branch
from
joeycarter/nanobind-catalyst-core
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+7
−192
Open
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
942b86b
[WIP] Replace pybind11 with nanobind in Catalyst's core
joeycarter 3bac603
Merge branch 'main' into joeycarter/nanobind-catalyst-core
joeycarter 0628a5e
Remove QuantumExtension MLIR python module
joeycarter bc96e28
Merge branch 'main' into joeycarter/nanobind-catalyst-core
joeycarter 69db0d3
Add nanobind to requirements
joeycarter 6f71341
Merge branch 'main' into joeycarter/nanobind-catalyst-core
joeycarter 7cc648f
Add nanobind to GitHub actions dependencies
joeycarter 9ecfc69
Merge branch 'main' into joeycarter/nanobind-catalyst-core
joeycarter 0e74f44
Fix issue with CMake Python versions
joeycarter aa778e0
Merge branch 'main' into joeycarter/nanobind-catalyst-core
joeycarter 78286a8
Remove min nanobind version requirement
joeycarter 5d05675
Revert "Remove QuantumExtension MLIR python module"
joeycarter 2722702
Fix compiler_driver CMake config
joeycarter c9aacab
Merge branch 'main' into joeycarter/nanobind-catalyst-core
joeycarter c27050e
Merge branch 'main' into joeycarter/nanobind-catalyst-core
joeycarter 6f3197a
[WIP] Remove QuantumExtension module
joeycarter ffdbf14
Add back in QuantumPythonModules for check-dialects
joeycarter 6b1a2b8
Remove commented-out code
joeycarter 8c76812
Add missing nanobind dependency
joeycarter 4c8d434
Merge branch 'main' into joeycarter/nanobind-catalyst-core
joeycarter e58f4ee
Merge branch 'main' into joeycarter/nanobind-catalyst-core
joeycarter 848963f
[Testing] Print out extra debug info for failing test
joeycarter a5893c7
Revert "[Testing] Print out extra debug info for failing test"
joeycarter 4214cda
[Testing] Print out extra CMake debug info
joeycarter ca39d4a
Require specific python version in cmake find_package
joeycarter e0feefb
Add PYTHON_VERSION_TO_FIND to GitHub workflows
joeycarter 052aeaf
Merge branch 'main' into joeycarter/nanobind-catalyst-core
joeycarter 5305261
Merge branch 'main' into joeycarter/nanobind-catalyst-core
joeycarter 4836d29
Specify Python root dir explicitly
joeycarter 20bcdaf
Merge branch 'main' into joeycarter/nanobind-catalyst-core
joeycarter df01e51
Remove all references to nanobind
joeycarter 8175b06
Update changelog
joeycarter 18c6d9c
Add "Internal changes" changelog section
joeycarter a179d96
Merge branch 'main' into joeycarter/nanobind-catalyst-core
joeycarter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can in the internal section, since it's not really user-facing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done (18c6d9c)
I didn't realize this at the time, but when I created the new dev changelog during the last release I had copied from a template that didn't have the "Internal changes" section, so I've added it here!