Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Catalyst to use the toml module in PennyLane #1275

Open
wants to merge 59 commits into
base: main
Choose a base branch
from
Open

Conversation

astralcai
Copy link
Contributor

@astralcai astralcai commented Nov 4, 2024

Context:

This PR is part of the new device capabilities initiative to improve feature parity between PennyLane and Catalyst. See this ADR for more context. A new TOML schema has been defined, and the relevant module implemented in PennyLane:

Description of the Change:

Benefits:

A step towards feature parity between PennyLane and Catalyst.

Possible Drawbacks:

  • Per discussions when the ADR was developed, operator.gates.decomp and operator.gates.matrix are removed, and the TOML file no longer prescribes to the framework how an operator should be handled. This will change the behaviour of decomposition for some circuits.

Related GitHub Issues:

[sc-71888]
[sc-71728]
[sc-71730]

@astralcai astralcai marked this pull request as ready for review November 11, 2024 17:15
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@@ -413,6 +413,8 @@ jobs:
python3 -m pip install cuda-quantum==0.6.0
python3 -m pip install oqc-qcaas-client
make frontend
python3 -m pip install --no-deps --force git+https://github.com/PennyLaneAI/pennylane@device-api-cap
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: revert these before merge

@astralcai astralcai changed the title [WIP] Update Catalyst to use the toml module in PennyLane Update Catalyst to use the toml module in PennyLane Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 6 lines in your changes missing coverage. Please review.

Project coverage is 97.92%. Comparing base (54df305) to head (9d8b763).

Files with missing lines Patch % Lines
frontend/catalyst/device/verification.py 86.36% 2 Missing and 1 partial ⚠️
frontend/catalyst/device/decomposition.py 90.47% 1 Missing and 1 partial ⚠️
frontend/catalyst/device/qjit_device.py 96.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1275      +/-   ##
==========================================
- Coverage   97.95%   97.92%   -0.04%     
==========================================
  Files          77       76       -1     
  Lines       11321    11222      -99     
  Branches      982      972      -10     
==========================================
- Hits        11090    10989     -101     
- Misses        181      182       +1     
- Partials       50       51       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants