-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Catalyst to use the toml module in PennyLane #1275
base: main
Are you sure you want to change the base?
Conversation
fix test_verification
Hello. You may have forgotten to update the changelog!
|
@@ -413,6 +413,8 @@ jobs: | |||
python3 -m pip install cuda-quantum==0.6.0 | |||
python3 -m pip install oqc-qcaas-client | |||
make frontend | |||
python3 -m pip install --no-deps --force git+https://github.com/PennyLaneAI/pennylane@device-api-cap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: revert these before merge
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1275 +/- ##
==========================================
- Coverage 97.95% 97.92% -0.04%
==========================================
Files 77 76 -1
Lines 11321 11222 -99
Branches 982 972 -10
==========================================
- Hits 11090 10989 -101
- Misses 181 182 +1
- Partials 50 51 +1 ☔ View full report in Codecov by Sentry. |
Context:
This PR is part of the new device capabilities initiative to improve feature parity between PennyLane and Catalyst. See this ADR for more context. A new TOML schema has been defined, and the relevant module implemented in PennyLane:
DeviceCapabilities
data class and the TOML module. pennylane#6407capabilities
to the device API pennylane#6433.Description of the Change:
toml
module and replaces all usages with imports from PennyLaneDeviceCapabilities
to match the new definition in [New Device Capabilities] Implement theDeviceCapabilities
data class and the TOML module. pennylane#6407Benefits:
A step towards feature parity between PennyLane and Catalyst.
Possible Drawbacks:
operator.gates.decomp
andoperator.gates.matrix
are removed, and the TOML file no longer prescribes to the framework how an operator should be handled. This will change the behaviour of decomposition for some circuits.Related GitHub Issues:
[sc-71888]
[sc-71728]
[sc-71730]