-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUILD SYSTEM] Remove zstd #1291
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1291 +/- ##
==========================================
+ Coverage 96.72% 97.95% +1.23%
==========================================
Files 56 77 +21
Lines 6800 11318 +4518
Branches 780 981 +201
==========================================
+ Hits 6577 11087 +4510
- Misses 173 181 +8
Partials 50 50 ☔ View full report in Codecov by Sentry. |
https://github.com/PennyLaneAI/catalyst/actions/runs/11729023698 these wheels do not contain zstd. The cache must be purged for this change to take effect. |
What was the reason to set it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Erick. No issue by me.
Do we know the size difference of the wheels with this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks Erick for handling this quickly
@mlxd : Looks like just 1 MB. It could have been more if we removed both zlib and zstd. But keeping zlib makes the difference very small. |
Context: We do not want to ship zstd.
Description of the Change: Removes zstd from LLVM build process.
Benefits: No zstd.
Possible Drawbacks: Possibly our bytecode takes more space.
Related GitHub Issues:
We will need to remove all caches for this change to take into effect.