Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import QubitDevice from devices module #897

Merged
merged 7 commits into from
Sep 11, 2024
Merged

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Sep 6, 2024

Context:

In PennyLane PR #6238 we will be deprecating top level access to QubitDevice.

Description of the Change:

Imports QubitDevice from pennylane.devices instead.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-71519]

Copy link
Contributor

github-actions bot commented Sep 6, 2024

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.70%. Comparing base (ee561f6) to head (a9a9567).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (ee561f6) and HEAD (a9a9567). Click for more details.

HEAD has 32 uploads less than BASE
Flag BASE (ee561f6) HEAD (a9a9567)
40 8
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #897       +/-   ##
===========================================
- Coverage   96.60%   82.70%   -13.90%     
===========================================
  Files         212       24      -188     
  Lines       29301     2180    -27121     
===========================================
- Hits        28306     1803    -26503     
+ Misses        995      377      -618     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albi3ro albi3ro requested a review from a team September 9, 2024 13:28
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a straightforward change, and all other CIs were successful, I will approve and consider that we can merge it without the last 4 GPU tests.

@maliasadi maliasadi added the urgent Mark a pull request as high priority label Sep 10, 2024
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @albi3ro! 🪂

@maliasadi maliasadi merged commit ffcb279 into master Sep 11, 2024
76 of 77 checks passed
@maliasadi maliasadi deleted the qubit-device-path-change branch September 11, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
urgent Mark a pull request as high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants