-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete references to the removed QubitStateVector
class
#985
Conversation
Hello. You may have forgotten to update the changelog!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggestions regarding the tests, see what you think :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #985 +/- ##
==========================================
- Coverage 97.75% 91.86% -5.89%
==========================================
Files 231 179 -52
Lines 36712 24858 -11854
==========================================
- Hits 35886 22835 -13051
- Misses 826 2023 +1197 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your nice work. Could you please check your PR formatting?
Also, please fill out the changelog. 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Looking over the indirect changes on code cov, I think codecov is just misbehaving as it sometimes does. We can try just rerunning the CI and seeing if that fixes it, and if not, we could even potentially override. It makes it look like we've removed All lightning tensor device tests somehow. Initializing |
**Context:** Completing the deprecation cycle of `QubitStateVector`. **Description of the Change:** 1. Update `deprecations.rst` 2. Update `changelog-dev.md` 3. Remove all deprecated source code Also, updated CI to install *latest* `pennylane-qiskit` rather than stable. References found in, - Catalyst: PennyLaneAI/catalyst#1289 - Lightning: PennyLaneAI/pennylane-lightning#985 - AQT: PennyLaneAI/pennylane-aqt#77 - Qulacs: PennyLaneAI/pennylane-qulacs#83 - Qiskit: PennyLaneAI/pennylane-qiskit#601 - Cirq: PennyLaneAI/pennylane-cirq#203 No references found in, - QML [sc-77482] --------- Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Context:
Completing the deprecation cycle of
QubitStateVector
(see PennyLaneAI/pennylane#6525)Description of the Change:
Removed all references to the deprecated source code.
[sc-77482]