-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SProd.terms()
method
#5287
Add SProd.terms()
method
#5287
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.35.0-rc0 #5287 +/- ##
==============================================
Coverage ? 99.64%
==============================================
Files ? 399
Lines ? 36635
Branches ? 0
==============================================
Hits ? 36506
Misses ? 129
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Thank you for adding this!
This reverts commit 0b65514.
@Qottmann could you elaborate what the intention here is? Is it that I believe previously it always returned a single coeff (the scalar) and a single observable (whether compound or not), but happy to be corrected here. |
In E.g. if you have some operator Frankly its not super urgent and probably a matter of taste what one prefers. more context here on slack |
Thanks @Qottmann! The change is not a problem for us as long as we're aware of the new behaviour, so feel free to re-merge this whenever convenient :) |
Was this added back or is that not planed anymore? |
@dime10 Still definitely wanted, but I guess is got backlogged. Probably too late for the next release, but we should definitely look into making this change together in tandem. |
Just checking in on this again 😅 |
@astralcai is now looking into this again with #5885 . But not going into the release since we know it's going to break things for catalyst. |
Missed to add
SProd.terms()
,SProd.ops
andSProd.coeffs
, fixing this here