-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prelim support for test-level markers #5517
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5517 +/- ##
==========================================
- Coverage 99.68% 99.67% -0.01%
==========================================
Files 415 416 +1
Lines 38898 38745 -153
==========================================
- Hits 38774 38620 -154
- Misses 124 125 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had two small ideas :)
Otherwise looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @mlxd, this looks great. It is most probably going to be quite useful in the future
Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mlxd 🎉 Looking forward to using them soon!
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
test directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
doc/releases/changelog-dev.md
file, summarizing thechange, and including a link back to the PR.
The PennyLane source code conforms to
PEP8 standards.
We check all of our code against Pylint.
To lint modified files, simply
pip install pylint
, and thenrun
pylint pennylane/path/to/file.py
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: This PR introduces new test-level markers for PennyLane, which can begin use for indication of where interactions take-place in the given suite. This forms part of the work on improving testing across the packages
[sc-61416]
Description of the Change: Add 3 new test-level markers for pytest:
unit_test
,integration_test
andsystem_test
. Some sample tests that fit into the 3 categories are added for examination purposes.Benefits: This will help us to structure our test-suite to better reflect localised tests from intermodule and interpackage tests.
Possible Drawbacks: 3 new markers to work with.
Related GitHub Issues: