Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update PennyLane pipeline logging support #5534

Merged
merged 5 commits into from
May 8, 2024

Conversation

mlxd
Copy link
Member

@mlxd mlxd commented Apr 17, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    test directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the doc/releases/changelog-dev.md file, summarizing the
    change, and including a link back to the PR.

  • The PennyLane source code conforms to
    PEP8 standards.
    We check all of our code against Pylint.
    To lint modified files, simply pip install pylint, and then
    run pylint pennylane/path/to/file.py.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context: This PR expands the logging functionality in PennyLane for both internal and inter-library (e.g. Lightning, Catalyst) use.

Description of the Change: Add support for decorator-defined logging functions, and updates the internal usage of logging with this.

Benefits: Allows more ease-of-use by developers to include logging with new functionality to the library.

Possible Drawbacks: Does not replace custom-defined log-level messages and trace-level expansion of functions.

Related GitHub Issues: #5528

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@mlxd mlxd changed the title Update PennyLane pipeline logging support [WIP] Update PennyLane pipeline logging support Apr 17, 2024
@mlxd
Copy link
Member Author

mlxd commented Apr 17, 2024

[sc-61591]

@mlxd mlxd force-pushed the update/logging_rules_pennylane branch from 543d8b2 to f095479 Compare May 8, 2024 20:00
@mlxd mlxd marked this pull request as ready for review May 8, 2024 20:45
@mlxd mlxd merged commit 3d1e81c into update/logging_rules_catalyst May 8, 2024
5 of 29 checks passed
@mlxd mlxd deleted the update/logging_rules_pennylane branch May 8, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant