-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc fix for fable template #5577
Conversation
Hello. You may have forgotten to update the changelog!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌 thanks guys!
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5577 +/- ##
==========================================
- Coverage 99.69% 99.68% -0.01%
==========================================
Files 410 411 +1
Lines 38278 38015 -263
==========================================
- Hits 38161 37897 -264
- Misses 117 118 +1 ☔ View full report in Codecov by Sentry. |
Context:
As pointed out by @isaacdevlugt, Fable template docs are unclear regarding the number of wires needed. This seeks to clarify that.
Description of the Change:
Docs changed to reflect that the # of wires needed is 2n+1
Benefits:
Users don't get confused by the seemingly random additional wire
Possible Drawbacks:
Related GitHub Issues: