Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc fix for fable template #5577

Merged
merged 7 commits into from
Apr 25, 2024
Merged

Doc fix for fable template #5577

merged 7 commits into from
Apr 25, 2024

Conversation

austingmhuang
Copy link
Contributor

@austingmhuang austingmhuang commented Apr 24, 2024

Context:
As pointed out by @isaacdevlugt, Fable template docs are unclear regarding the number of wires needed. This seeks to clarify that.

Description of the Change:
Docs changed to reflect that the # of wires needed is 2n+1

Benefits:
Users don't get confused by the seemingly random additional wire

Possible Drawbacks:

Related GitHub Issues:

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link
Contributor

@isaacdevlugt isaacdevlugt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 thanks guys!

pennylane/templates/subroutines/fable.py Outdated Show resolved Hide resolved
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
austingmhuang and others added 2 commits April 24, 2024 17:56
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.68%. Comparing base (9151477) to head (0050853).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5577      +/-   ##
==========================================
- Coverage   99.69%   99.68%   -0.01%     
==========================================
  Files         410      411       +1     
  Lines       38278    38015     -263     
==========================================
- Hits        38161    37897     -264     
- Misses        117      118       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trbromley trbromley added this to the v0.36 milestone Apr 25, 2024
@austingmhuang austingmhuang merged commit 747b1ff into master Apr 25, 2024
38 checks passed
@austingmhuang austingmhuang deleted the fable_doc_fix branch April 25, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants