Removing the wire_map argument from qml.is_commuting

[PietropaoloFrisoni]

Context: Part of deprecations and removals for pennylane-0.37

Description of the Change: Removed the wire_map argument from qml.is_commuting.

[sc-58988]

[trbromley]

@glassnotes @josh146, looking at the commit history you were both involved in adding qml.is_commuting. Do you know why we added a wire_map? Our thinking has been that a mapping of wires does not alter whether two operations commute, but I want to check if we're missing something.

[josh146]

@trbromley I'm sorry, I don't recall the reasoning here :( Do you have a link to the original PR?

[albi3ro]

This makes me happy :)

[albi3ro]

@trbromley I'm sorry, I don't recall the reasoning here :( Do you have a link to the original PR?

This was added in #3033 because grouping.utils.is_commuting used it, and grouping.utils.is_commuting used it because it converted the observables to binary form. We no longer used said binary form because it isn't as efficient as using the pauli rep. And even if we ever did use a binary form, we could just infer the wire order from the observables...

[glassnotes]

@glassnotes @josh146, looking at the commit history you were both involved in adding qml.is_commuting. Do you know why we added a wire_map? Our thinking has been that a mapping of wires does not alter whether two operations commute, but I want to check if we're missing something.

Yeah I think it was added to support taking the symplectic inner product to evaluate commutativity, and the functions that convert to binary symplectic rep required a wire order.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.68%. Comparing base (ab8d739) to head (7ed4392).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5660      +/-   ##
==========================================
- Coverage   99.69%   99.68%   -0.02%     
==========================================
  Files         412      412              
  Lines       38663    38367     -296     
==========================================
- Hits        38545    38245     -300     
- Misses        118      122       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[trbromley]

Thanks everyone! Ok, looks like a wire map is no longer needed here and we'll proceed with removing it.

[PietropaoloFrisoni]

Thanks everyone. I'll merge this PR as soon as I have a second approval

[astralcai]

Don't forget to update the deprecations page as well

[PietropaoloFrisoni]

@astralcai I left a comment about that above. I'll repost it here;

As mentioned on Shortcut, it has been decided not to go through a deprecation cycle because the presence of wire_map is not functional and can be viewed more as a bug than a feature.

Therefore, the doc/development/deprecations.rst file has not been modified in this PR.