[BUG] Fix a fermi sentence bug in bravyi_kitaev #5671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Jaybsoni
approved these changes
May 8, 2024
obliviateandsurrender
approved these changes
May 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5671 +/- ##
==========================================
- Coverage 99.69% 99.68% -0.01%
==========================================
Files 412 412
Lines 38663 38372 -291
==========================================
- Hits 38545 38252 -293
- Misses 118 120 +2 ☔ View full report in Codecov by Sentry. |
mudit2812
pushed a commit
that referenced
this pull request
May 8, 2024
**Context:** There is a wrong call in bravyi_kitaev when the input object is FermiSentence, which is only observed for some specific inputs that were not covered by our current tests. The PR fixes the bug and adds an extra test to check the accuracy. **Description of the Change:** **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
There is a wrong call in bravyi_kitaev when the input object is FermiSentence, which is only observed for some specific inputs that were not covered by our current tests. The PR fixes the bug and adds an extra test to check the accuracy.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: