Allow abstract Boolean measurement results as a parameter to qml.sample #5673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... qml.sample for Catalyst.
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5673 +/- ##
==========================================
- Coverage 99.68% 99.67% -0.01%
==========================================
Files 416 416
Lines 39049 38812 -237
==========================================
- Hits 38925 38687 -238
- Misses 124 125 +1 ☔ View full report in Codecov by Sentry. |
|
Thanks @dime10! Would you mind linking the associated SC story? |
albi3ro
reviewed
May 10, 2024
mudit2812
reviewed
May 10, 2024
dime10
changed the title
albi3ro
approved these changes
May 24, 2024
mudit2812
approved these changes
May 24, 2024
dime10
added a commit
to PennyLaneAI/catalyst
that referenced
this pull request
May 27, 2024
This PR can be merged after PennyLaneAI/pennylane#5673. Introduce support for `m = measure(0); qml.sample(m)` in Catalyst programs. In conjunction with ongoing work on MCM support, this will allow returning `shots` number of MCM samples from a quantum program. [sc-62096]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows
qml.sample(and implicitly other measurement processes) to accept a Boolean tracer in the observable parameter, similar to what is already done for theMeasurementValuevalue object. Thewiresattribute will be empty in this case.[sc-62096]