-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom boolean functions for supporting noise models #5674
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5674 +/- ##
==========================================
- Coverage 99.68% 99.67% -0.01%
==========================================
Files 415 417 +2
Lines 38898 38748 -150
==========================================
- Hits 38774 38623 -151
- Misses 124 125 +1 ☔ View full report in Codecov by Sentry. |
Thanks @obliviateandsurrender! Would you mind linking the corresponding SC story? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go 💯. A left a few comments, also would suggest adding some tests for wires_in and wires_eq comparing with operations (specifically with operations of multiple wires like CNOT or some template)
Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, good job! Here are a few minor comments.
I've been also doing a lot of tricky testing and I see it's bulletproof 😎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @obliviateandsurrender! Really excited for this feature and thank you for making it a reality. I've left comments primarily around the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @obliviateandsurrender, approved! I'll look at the follow up PRs over the coming days.
Context: We aim to have a custom boolean function that could serve as a building block for creating noise models.
Description of the Change:
BooleanFn
to work with arbitraryargs
andkwargs
.NoiseConditionals
as a class that helps buildBooleanFn
required for creating noise models.wire/op_eq/in
to enhance the building experience for the aboveBooleanFn
.Benefits:
Possible Drawbacks:
Related GitHub Issues: [sc-63080]