-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resources()
to qml.TrotterProduct
class
#5680
Conversation
Hello. You may have forgotten to update the changelog!
|
[sc-62523] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5680 +/- ##
==========================================
+ Coverage 99.51% 99.66% +0.14%
==========================================
Files 415 415
Lines 39985 39505 -480
==========================================
- Hits 39791 39372 -419
+ Misses 194 133 -61 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jaybsoni, please note my minor comments before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jaybsoni!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jaybsoni, looks good to me! Optionally, you might want to add an integration test with qml.Tracker
too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jaybsoni!
Context:
qml.TrotterProduct()
now has error tracking functionality, but ins't compatible with resource tracking. This bug fix adds native resource tracking functionality to allow for compatibility with both pipelines.Description of the Change:
Inherit from
ResourcesOperation
class as well and directly implement the resource method.Benefits:
Allows for tracking resources without decomposing the template.
Possible Drawbacks:
If we change the target gate-set or want to decompose further, then this method is no longer accurate.
Related GitHub Issues:
Replicating most of this PR post release.