transforms.insert: Update docs, improve decomposition
#5681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
dwierichs
added
the
review-ready 👌
trbromley
reviewed
May 13, 2024
dwierichs
commented
May 13, 2024
albi3ro
approved these changes
May 14, 2024
dwierichs
added
merge-ready ✔️
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5681 +/- ##
==========================================
- Coverage 99.68% 99.67% -0.01%
==========================================
Files 414 414
Lines 38814 38527 -287
==========================================
- Hits 38691 38402 -289
- Misses 123 125 +2 ☔ View full report in Codecov by Sentry. |
Shiro-Raven
pushed a commit
that referenced
this pull request
May 15, 2024
**Context:** The first example in the docs of `qml.transforms.insert` was reported to not be working [here](https://discuss.pennylane.ai/t/qml-device-error-with-qiskit-aer/4556/9). Other examples also do not work. **Description of the Change:** This PR changes the docs examples to work. It also replicates the change in #5424 to use `devices.preprocess.decompose` instead of `tape.expand`, adding support for non-commuting measurements (which is unrelated to the transform anyways), and removing the need for a custom error to be raised. **Benefits:** Docs examples work. Non-commuting measurements support. **Possible Drawbacks:** Similar to #5424, this introduces cross-dependency to the devices module. **Related GitHub Issues:**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The first example in the docs of
qml.transforms.insertwas reported to not be working here.Other examples also do not work.
Description of the Change:
This PR changes the docs examples to work.
It also replicates the change in #5424 to use
devices.preprocess.decomposeinstead oftape.expand, adding support for non-commuting measurements (which is unrelated to the transform anyways), and removing the need for a custom error to be raised.Benefits:
Docs examples work.
Non-commuting measurements support.
Possible Drawbacks:
Similar to #5424, this introduces cross-dependency to the devices module.
Related GitHub Issues: