Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for noise models #5684

Merged
merged 108 commits into from
Jun 12, 2024
Merged

Add support for noise models #5684

merged 108 commits into from
Jun 12, 2024

Conversation

obliviateandsurrender
Copy link
Contributor

Context: Adds the ability to create noise models via qml.NoiseModel.

Description of the Change: Adds a NoiseModel class in noise_model.py in the qml.noise module.

Benefits:

Possible Drawbacks:

Related GitHub Issues: [sc-63081], [sc-63082]

Copy link
Contributor

@trbromley trbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pennylane/noise/noise_model.py Outdated Show resolved Hide resolved
pennylane/noise/noise_model.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Jaybsoni Jaybsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏼

Base automatically changed from noise-models-1 to master June 11, 2024 15:41
Copy link
Contributor

@trbromley trbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @obliviateandsurrender, just a few comments here. Looks awesome

pennylane/noise/noise_model.py Show resolved Hide resolved
pennylane/noise/noise_model.py Outdated Show resolved Hide resolved
pennylane/noise/noise_model.py Outdated Show resolved Hide resolved
Copy link
Contributor

@trbromley trbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@obliviateandsurrender obliviateandsurrender enabled auto-merge (squash) June 12, 2024 16:24
@obliviateandsurrender obliviateandsurrender merged commit c6a7cb0 into master Jun 12, 2024
40 checks passed
@obliviateandsurrender obliviateandsurrender deleted the noise-models-2 branch June 12, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants