Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to Autoray >=0.6.11 #5687

Merged
merged 18 commits into from
May 22, 2024
Merged

Pin to Autoray >=0.6.11 #5687

merged 18 commits into from
May 22, 2024

Conversation

dwierichs
Copy link
Contributor

Context:
Autoray 0.6.10 had two bugs, Autoray 0.6.11 has those fixed and is out now.

Description of the Change:
Revert recent pinning of autoray version in requirements-ci.txt and requirements.txt

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.67%. Comparing base (0dcba44) to head (eb62780).
Report is 252 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5687      +/-   ##
==========================================
- Coverage   99.68%   99.67%   -0.01%     
==========================================
  Files         415      415              
  Lines       38886    38600     -286     
==========================================
- Hits        38762    38475     -287     
- Misses        124      125       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

requirements.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, thanks @dwierichs .

requirements.txt Outdated Show resolved Hide resolved
@vincentmr
Copy link
Contributor

Give me a few minutes and I'll run the all-interfaces tests. Anything else?

I tested all autoray versions in a loop like

for ver in {1..11}; do
    fver=0.6.${ver}
    pip install autoray==$fver
    OMP_PROC_BIND=false pytest tests --tb=native -n auto  -m "all_interfaces" --disable-opmath=False > pytest_$fver.log
done

and they all failed ~40 tests of all-interfaces tests, but ver=11.

@dwierichs dwierichs changed the title Unpin Autoray version Pin to Autoray 0.6.11 May 16, 2024
@dwierichs dwierichs changed the title Pin to Autoray 0.6.11 Pin to Autoray >=0.6.11 May 16, 2024
@dwierichs dwierichs requested a review from albi3ro May 16, 2024 18:53
@dwierichs dwierichs enabled auto-merge (squash) May 22, 2024 13:15
@dwierichs dwierichs merged commit 3c08049 into master May 22, 2024
38 checks passed
@dwierichs dwierichs deleted the unpin-autoray branch May 22, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants