New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding `QROM` template #5688

Merged

KetpuntoG merged 48 commits into master from qrom_template

Jun 6, 2024

Contributor

KetpuntoG commented May 14, 2024 •

edited

Loading

Template for QROM, a technique to embed classical data on a quantum computer
Code example:

 bitstrings = ["010", "111", "110", "000"]

   dev = qml.device("default.qubit", shots = 1)
   @qml.qnode(dev)
   def circuit():

     # third index
     qml.BasisEmbedding(2, wires = [0,1])

     qml.QROM(b = bitstrings,
             control_wires = [0,1],
             target_wires = [2,3,4],
             work_wires = [5,6,7])

     return qml.sample(wires = [2,3,4])

>>> print(circuit())
[1 1 0]

KetpuntoG added 2 commits

May 13, 2024 19:14


qrom

6c1e795


adding tests, fixing some issues

7cd3add

Contributor

github-actions bot commented May 14, 2024

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

A one-to-two sentence description of the change. You may include a small working example for new features.
A link back to this PR.
Your name (or GitHub username) in the contributors section.

Contributor Author

KetpuntoG commented May 14, 2024

codecov bot commented May 14, 2024 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.66%. Comparing base (087c1c8) to head (aadc12c).
Report is 252 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5688      +/-   ##
==========================================
- Coverage   99.66%   99.66%   -0.01%     
==========================================
  Files         414      415       +1     
  Lines       39490    39305     -185     
==========================================
- Hits        39358    39172     -186     
- Misses        132      133       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

KetpuntoG added 18 commits

May 15, 2024 09:35


pylint

5fa0683


docs

bde0cf4


pylint

e047b38


Update qrom.py

bd792c1


Update qrom.py

b4305d9


tests fix

4870e39


docs

88d1930


Update qrom.py

28ca927


Update qrom.py

e56be8e


Update test_qubitization.py

134fcad


Update qrom.py

d76e415


Update test_qubitization.py

ce7d6ba


Update test_qrom.py

657f652


comments to clarify code

4e04ec3


Update qrom.py

aeead30


Merge branch 'master' into qrom_template

e3ff382


Update qrom.py

4fae9d5


Merge branch 'qrom_template' of https://github.com/PennyLaneAI/pennylane

051b986

 into qrom_template

KetpuntoG changed the title ~~[WIP] Adding QROM template~~ Adding QROM template


Update qrom.py

8515c59

KetpuntoG requested review from Jaybsoni and soranjh

May 17, 2024 17:33

KetpuntoG added 3 commits

May 23, 2024 11:51


b -> bitstrings

6cd706c


pylint

f711d91


Merge branch 'master' into qrom_template

12d5f92

trbromley reviewed

View reviewed changes

pennylane/templates/subroutines/qrom.py Show resolved Hide resolved


[skip-ci]

b6f4428

DSGuala self-requested a review

May 28, 2024 18:06

soranjh requested changes

View reviewed changes

Contributor

soranjh left a comment

Thanks @KetpuntoG. Added my final comments, will approve when they are addressed.

pennylane/templates/subroutines/qrom.py Outdated Show resolved Hide resolved

pennylane/templates/subroutines/qrom.py Show resolved Hide resolved

pennylane/templates/subroutines/qrom.py Outdated Show resolved Hide resolved

pennylane/templates/subroutines/qrom.py Outdated Show resolved Hide resolved

pennylane/templates/subroutines/qrom.py Outdated Show resolved Hide resolved

pennylane/templates/subroutines/qrom.py Show resolved Hide resolved

pennylane/templates/subroutines/qrom.py Outdated Show resolved Hide resolved

tests/templates/test_subroutines/test_qrom.py Outdated Show resolved Hide resolved

tests/templates/test_subroutines/test_qrom.py Outdated Show resolved Hide resolved

tests/templates/test_subroutines/test_qrom.py Outdated Show resolved Hide resolved

Jaybsoni reviewed

View reviewed changes

Contributor

Jaybsoni left a comment

Looks very good, I left a few suggestions and comments! I know that this template doesn't have any trainable parameters, but we should still check that it is jit-able.

happy to review again once you have addressed the comments. Should be good to go soon!

pennylane/templates/subroutines/qrom.py Show resolved Hide resolved

pennylane/templates/subroutines/qrom.py Show resolved Hide resolved

pennylane/templates/subroutines/qrom.py Outdated Show resolved Hide resolved

pennylane/templates/subroutines/qrom.py Show resolved Hide resolved

pennylane/templates/subroutines/qrom.py Outdated Show resolved Hide resolved

pennylane/templates/subroutines/qrom.py Show resolved Hide resolved

pennylane/templates/subroutines/qrom.py Outdated Show resolved Hide resolved

pennylane/templates/subroutines/qrom.py Outdated Show resolved Hide resolved

KetpuntoG and others added 3 commits

June 4, 2024 15:51


Apply suggestions from code review

5afa6e4

suggestions from code review

Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>


final comments review

1e2876e


Merge branch 'master' into qrom_template

781515d

trbromley approved these changes

View reviewed changes

Contributor

trbromley left a comment

Thanks @KetpuntoG!

KetpuntoG added 3 commits

June 5, 2024 08:46


fix jax test

11ef6e0


Update test_templates.py

5235b9c


Merge branch 'master' into qrom_template

d9b7e9d

albi3ro reviewed

View reviewed changes

pennylane/templates/subroutines/qrom.py Outdated Show resolved Hide resolved

dwierichs reviewed

View reviewed changes

pennylane/templates/subroutines/qrom.py Outdated Show resolved Hide resolved

KetpuntoG and others added 3 commits

June 5, 2024 11:34


adding _primitive_blind_call

3a5f139


[skip-ci]

f3c9e4f

[skip-ci]

Co-authored-by: David Wierichs <david.wierichs@xanadu.ai>


final final

c2a359c

KetpuntoG requested a review from soranjh

June 5, 2024 17:12

soranjh approved these changes

View reviewed changes

Contributor

soranjh left a comment

Looks good @KetpuntoG, ready to go.

pennylane/templates/subroutines/qrom.py Outdated Show resolved Hide resolved

pennylane/templates/subroutines/qrom.py Outdated Show resolved Hide resolved

KetpuntoG and others added 3 commits

June 5, 2024 18:49


Apply suggestions from code review

d9d85f2

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>


Merge branch 'master' into qrom_template

1dd5e9c


Update test_qrom.py

b1b2555

Jaybsoni reviewed

View reviewed changes

pennylane/templates/subroutines/qrom.py Show resolved Hide resolved

Jaybsoni reviewed

View reviewed changes

pennylane/templates/subroutines/qrom.py Show resolved Hide resolved

Jaybsoni reviewed

View reviewed changes

pennylane/templates/subroutines/qrom.py Outdated Show resolved Hide resolved

Jaybsoni approved these changes

View reviewed changes

Contributor

Jaybsoni left a comment

Great work! Just a few, non-blocking comments

KetpuntoG added 2 commits

June 6, 2024 12:35


reference format

8ac2905


Merge branch 'master' into qrom_template

aadc12c

KetpuntoG merged commit 38b3e74 into master

40 checks passed

KetpuntoG deleted the qrom_template branch

June 6, 2024 17:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet