add_noise transform for adding noise models
#5718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaybsoni
reviewed
Jun 10, 2024
There was a problem hiding this comment.
Looks good to me! Added a few questions and some nitpicking comments. Happy to approve once it's addressed.
One general suggestion for the tests, It feels abit choppy that some of the tests fall inside the class while others don't. I think you could probably put all of them in the class or remove the class completely. There doesn't seem to be any benefit to either, but having both makes things a little confusing. I leave the final decision to you though, so feel free to ignore.
trbromley
reviewed
Jun 12, 2024
There was a problem hiding this comment.
Thanks @obliviateandsurrender, just a few comments for now.
soranjh
reviewed
Jun 12, 2024
soranjh
approved these changes
Jun 19, 2024
mudit2812
pushed a commit
that referenced
this pull request
Jul 2, 2024
**Context:** Adds a transform for adding `NoiseModels`. **Description of the Change:** Adds `add_noise.py` under `pennylane/transforms` that gives the said method for inserting operations according to a provided noise model. **Benefits:** We support noise models. **Possible Drawbacks:** None. **Related GitHub Issues:** [sc-64843] --------- Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Adds a transform for adding
NoiseModels.Description of the Change: Adds
add_noise.pyunderpennylane/transformsthat gives the said method for inserting operations according to a provided noise model.Benefits: We support noise models.
Possible Drawbacks: None.
Related GitHub Issues: [sc-64843]