Added |2> -> |1> amplitude damping to amplitude damping. #5757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trbromley
approved these changes
May 29, 2024
|
@mudit2812 I added this. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5757 +/- ##
==========================================
- Coverage 99.67% 99.66% -0.01%
==========================================
Files 414 414
Lines 39310 39021 -289
==========================================
- Hits 39181 38891 -290
- Misses 129 130 +1 ☔ View full report in Codecov by Sentry. |
|
Hi @albi3ro, @glassnotes, @mudit2812, @trbromley; I didn't tag you all earlier as I didn't intend to make this a full PR, I missclicked when trying to make it a draft. I fixed the issues and it is finalized now, ready for review. |
mudit2812
approved these changes
May 31, 2024
glassnotes
approved these changes
Jun 1, 2024
There was a problem hiding this comment.
Good catch @Gabriel-Bottrill , thanks for improving this channel implementation!
Co-authored-by: Olivia Di Matteo <2068515+glassnotes@users.noreply.github.com>
glassnotes
added a commit
that referenced
this pull request
Jun 6, 2024
**Context:** The QutritAmplitudeDamping channel #5503 and #5757 variable names are named with numbers, when making the TritFlip channel #5784 I realized that it would be better to specify subspaces for clarity. This PR is meant to change the name of QutritAmplitudeDamping's variables. **Description of the Change:** Change the name of the QutritAmplitudeDamping channel's variables from gamma_1, gamma_2, and gamma_3 to gamma_01, gamma_02, and gamma_12, respectively. **Benefits:** Makes the code more clear for which variables affect which subspace, reducing the need to check the docs. **Possible Drawbacks:** Changes the name of variables of development code. **Related GitHub Issues:** N/A --------- Co-authored-by: Gabriel Bottrill <bottrill@student.ubc.ca> Co-authored-by: Olivia Di Matteo <2068515+glassnotes@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
I recently added
qml.QutritAmplitudeDampingbased on specifications from this paper. This paper only considers the transition from |2> to |0>, in reality on a super conducting device it is more likely to have a |2> to |1> transition. This PR adds a variable and a new Kraus matrix toqml.QutritAmplitudeDampingto allow for the simulation of the |2> to |1> transition.Description of the Change:
Adds a new variable, \gamma_3, to
qml.QutritAmplitudeDampingthat defines the new Kraus matrix K_3. This new Kraus operator allows for the simulation of |2> to |1> relaxations.Benefits:
Allows for simulation of |2> to |1> relaxation. This will make for more accurate simulations and is useful for measurement error for qutrits.
Possible Drawbacks:
This changes
qml.QutritAmplitudeDampingand adds an extra parameter, the naming may be a bit more confusing.Related GitHub Issues:
N/A