Make Conditional a SymbolicOp
#5772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implement eigvals, matrix, and decomposition
|
Hello. You may have forgotten to update the changelog!
|
EmilianoG-byte
changed the title
Conditional a SymbolicOp Conditional a SymbolicOp
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5772 +/- ##
==========================================
- Coverage 99.66% 99.66% -0.01%
==========================================
Files 414 414
Lines 39466 39194 -272
==========================================
- Hits 39334 39061 -273
- Misses 132 133 +1 ☔ View full report in Codecov by Sentry. |
PietropaoloFrisoni
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
That's amazing @EmilianoG-byte , thanks!
I just left a couple of minor suggestions 👍
Co-authored-by: Pietropaolo Frisoni <pietropaolo.frisoni@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The
Conditionalclass currently inherits fromOperator, such that many attributes and methods are missing.Description of the Change:
By switching to inherit from
SymbolicOp, theConditionalclass now includes some common default behaviour, such as deferring properties to the base class, copying the base class during a shallow copy, and updating the metadata of the base operator during queueing.In addition, other relevant representations have been added and tested, e.g.:
matrix,adjoint,diagonalizing_gates, andeigvals.As part of the work needed for this PR, new dispatches for
qml.Conditionalandqml.MeasurementValuehave been added to theqml.equal()function.Benefits:
Seamlessly inheritance of properties and basic methods implemented by
SymbolicOp, including differing of properties.Possible Drawbacks:
Have to make sure that is not a breaking change as some attributes/methods of
Conditionalare changed.Need to rethink approach for decomposition of
Conditionaloperators.[sc-61356]