Implement assert equal for operators #5780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These had to be implemented to fix tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5780 +/- ##
==========================================
- Coverage 99.67% 99.67% -0.01%
==========================================
Files 420 420
Lines 40084 39842 -242
==========================================
- Hits 39955 39713 -242
Misses 129 129 ☔ View full report in Codecov by Sentry. |
This reverts commit c5788da.
Tarun-Kumar07
changed the title
This was referenced Jun 3, 2024
# Conflicts: # pennylane/ops/functions/equal.py # tests/ops/functions/test_equal.py
albi3ro
approved these changes
Jun 11, 2024
mudit2812
reviewed
Jun 11, 2024
|
Nice work everyone! 🎉 Just to clarify, @Tarun-Kumar07 and @EuGig how much would both of you say that you contributed to this PR? |
|
Hey @isaacdevlugt , all the changes in this PR were done by me :) |
|
Hi @trbromley, I noticed that the auto-merge was disabled. Is everything okay? |
|
Hey @Tarun-Kumar07, no concerns here 😄. We will merge your PR by the end of the day (around 5pm ET). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
PennyLane currently has a
qml.equalfunction which can be used to check the equality of operators, measurements, and tapes. New frameworkassert_equalhas been developed which along with checking equality tells the reason for equality failure.Description of the Change:
assert_equalfor different type of operators mentioned in #5644 and #5648Benefits:
assert_equalsfor mentioned operators above return more granular reason of failure. This eases debugging of tests.Possible Drawbacks:
More maintenance
Related GitHub Issues:
Fixes #5644
Fixes #5648