Clean up Device.batch_transform to use split_non_commuting
#5828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5828 +/- ##
==========================================
- Coverage 99.68% 99.67% -0.01%
==========================================
Files 421 421
Lines 40464 40203 -261
==========================================
- Hits 40335 40073 -262
- Misses 129 130 +1 ☔ View full report in Codecov by Sentry. |
dwierichs
requested changes
Jun 12, 2024
There was a problem hiding this comment.
Nice @astralcai !
Took me some time to dig through the logic, but it is nicer now! :)
Also good to see the reduction of number of terms in some scenarios! 🎉
Had only a few quite small comments, basically ready to approve.
dwierichs
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
#5729 introduced the unified
split_non_commuting. Now the legacy device can usesplit_non_commutingin all scenarios.Description of the Change:
Cleans up
batch_transformto usesplit_non_commutingBenefits:
Cleaner code, prepares for the deprecation of
hamiltonian_expandandsum_expand.Related GitHub Issues:
[sc-61253]