-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added jax support to private function _qsp_to_qsvt()
which handles convention changes.
#5853
Conversation
Hello. You may have forgotten to update the changelog!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jaybsoni.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5853 +/- ##
==========================================
- Coverage 99.67% 99.66% -0.01%
==========================================
Files 425 425
Lines 40751 40457 -294
==========================================
- Hits 40618 40323 -295
- Misses 133 134 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick turnaround on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jaybsoni, definitely useful to have the new math function!
Co-authored-by: David Ittah <dime10@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
…convention changes. (#5853) **Context:** Allow for `qml.qsvt()` to accept phase angles as jax arrays and perform convention conversions. --------- Co-authored-by: David Ittah <dime10@users.noreply.github.com>
Context:
Allow for
qml.qsvt()
to accept phase angles as jax arrays and perform convention conversions.