Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert_equal is imported top level #5858

Merged
merged 20 commits into from
Jun 19, 2024
Merged

assert_equal is imported top level #5858

merged 20 commits into from
Jun 19, 2024

Conversation

astralcai
Copy link
Contributor

@astralcai astralcai commented Jun 14, 2024

Context
assert_equal basically asserts qml.equal but tells you why something isn't equal when it fails.

Changes

  • Make qml.ops.functions.equal.assert_equal accessible as qml.assert_equal
  • Replaces use of assert qml.equal() with qml.assert_equal()

[sc-66069]

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.67%. Comparing base (ab8b6d5) to head (40be5fa).
Report is 245 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5858      +/-   ##
==========================================
- Coverage   99.68%   99.67%   -0.01%     
==========================================
  Files         421      421              
  Lines       40499    40203     -296     
==========================================
- Hits        40370    40073     -297     
- Misses        129      130       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astralcai astralcai added this to the v0.37 milestone Jun 17, 2024
@astralcai astralcai changed the base branch from master to trotter-test June 17, 2024 18:10
@astralcai astralcai marked this pull request as ready for review June 17, 2024 18:40
Base automatically changed from trotter-test to master June 18, 2024 18:44
Copy link
Contributor

@dwierichs dwierichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to find a problem, did not succeed...
Thanks for this @astralcai 💯

tests/ops/functions/test_commutator.py Outdated Show resolved Hide resolved
Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@astralcai astralcai merged commit c874bbd into master Jun 19, 2024
40 checks passed
@astralcai astralcai deleted the assert-equal-import branch June 19, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants