Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move openfermion functions to correct modules #5863

Merged
merged 7 commits into from
Jun 18, 2024
Merged

Conversation

soranjh
Copy link
Contributor

@soranjh soranjh commented Jun 17, 2024

Context:
The qchem functions that depend on openfermion and pyscf are all collected in the openfermion_pyscf module.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.67%. Comparing base (d90137d) to head (9921079).
Report is 247 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5863      +/-   ##
==========================================
- Coverage   99.68%   99.67%   -0.01%     
==========================================
  Files         421      421              
  Lines       40461    40165     -296     
==========================================
- Hits        40332    40035     -297     
- Misses        129      130       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soranjh
Copy link
Contributor Author

soranjh commented Jun 17, 2024

[sc-59835]

@soranjh soranjh changed the title [WIP] move openfermion functions to correct modules Move openfermion functions to correct modules Jun 17, 2024
@soranjh soranjh marked this pull request as ready for review June 17, 2024 17:47
Copy link
Contributor

@obliviateandsurrender obliviateandsurrender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go! Don't forget to add it to the changelog here.

Copy link
Contributor

@ddhawan11 ddhawan11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@soranjh soranjh merged commit 03211a2 into master Jun 18, 2024
40 checks passed
@soranjh soranjh deleted the qchem_molecular_dipole branch June 18, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants