Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support qubit operator in from_openfermion #5881

Merged
merged 17 commits into from
Jun 21, 2024
Merged

Conversation

soranjh
Copy link
Contributor

@soranjh soranjh commented Jun 20, 2024

Context:
The from_openfermion function is updated to supports the conversion of qubit operators in addition to fermionic operators.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.66%. Comparing base (50e009a) to head (7d37173).
Report is 241 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5881      +/-   ##
==========================================
+ Coverage   99.61%   99.66%   +0.05%     
==========================================
  Files         422      422              
  Lines       40697    40355     -342     
==========================================
- Hits        40539    40221     -318     
+ Misses        158      134      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soranjh soranjh marked this pull request as ready for review June 20, 2024 13:14
@soranjh soranjh changed the title [WIP] support qubit operator in from_openfermion Support qubit operator in from_openfermion Jun 20, 2024
Copy link
Contributor

@ddhawan11 ddhawan11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @soranjh.

Copy link
Contributor

@obliviateandsurrender obliviateandsurrender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor optional comments, but not blocking!

pennylane/qchem/convert_openfermion.py Outdated Show resolved Hide resolved
pennylane/qchem/convert_openfermion.py Outdated Show resolved Hide resolved
@soranjh soranjh merged commit 8fec135 into master Jun 21, 2024
40 checks passed
@soranjh soranjh deleted the openfermion_pl_conversion branch June 21, 2024 04:01
mudit2812 pushed a commit that referenced this pull request Jul 2, 2024
**Context:**
The `from_openfermion` function is updated to supports the conversion of
qubit operators in addition to fermionic operators.

**Description of the Change:**

**Benefits:**

**Possible Drawbacks:**

**Related GitHub Issues:**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants