Small dynamic_one_shot change to account for Catalyst updates
#5888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
dime10
reviewed
Jun 20, 2024
vincentmr
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Looks good to me, I'm glad to see this is coming in. Thanks @mudit2812 .
dime10
reviewed
Jun 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5888 +/- ##
==========================================
- Coverage 99.67% 99.66% -0.01%
==========================================
Files 425 425
Lines 40753 40457 -296
==========================================
- Hits 40620 40323 -297
- Misses 133 134 +1 ☔ View full report in Codecov by Sentry. |
mudit2812
added a commit
that referenced
this pull request
Jul 2, 2024
**Context:** Some updates are being made to Catalyst for mid-circuit measurements that are dependent on the changes in this PR. **Description of the Change:** * Change reference in `dynamic_one_shot` to catalyst's `MidCircuitMeasure.out_classical_tracers` to `MidCircuitMeasure.mcm_tracer`. * Change `MidMeasureMP.name` to be more general. This is because `MidCircuitMeasure` will soon inherit `MidMeasureMP`, and this change makes more sense than adding a `name` property to `MidCircuitMeasure`. **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:**
mudit2812
added a commit
that referenced
this pull request
Jul 2, 2024
**Context:** Some changes were added preemptively in #5888 for changes that were being added to Catalyst in PennyLaneAI/catalyst#832, but that PR is not merged, so the changes from #5888 have to be reverted. **Description of the Change:** Reverted changes from #5888 Some updates to catalyst-`split_non_commuting` caused test failures in Catalyst in cases where terminal measurements contain mid-circuit measurements, so `qml.equal` was updated to handle abstract measurement values. **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Some updates are being made to Catalyst for mid-circuit measurements that are dependent on the changes in this PR.
Description of the Change:
dynamic_one_shotto catalyst'sMidCircuitMeasure.out_classical_tracerstoMidCircuitMeasure.mcm_tracer.MidMeasureMP.nameto be more general. This is becauseMidCircuitMeasurewill soon inheritMidMeasureMP, and this change makes more sense than adding anameproperty toMidCircuitMeasure.Benefits:
Possible Drawbacks:
Related GitHub Issues: