-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor program capture fixes #5889
Conversation
Hello. You may have forgotten to update the changelog!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @albi3ro, LGTM!
May I ask to add the PR to the changelog entry for the capture effort?
Co-authored-by: David Wierichs <david.wierichs@xanadu.ai>
changelog link added. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5889 +/- ##
==========================================
- Coverage 99.67% 99.66% -0.01%
==========================================
Files 422 425 +3
Lines 40651 40455 -196
==========================================
- Hits 40518 40321 -197
- Misses 133 134 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing out the post-approval changes!
**Context:** Catalyst PR #837 (PennyLaneAI/catalyst#837) needs a couple minor updates to the capture module. **Description of the Change:** 1) makes it possible to do `from pennylane.capture import AbstractOperator, AbstractMeasurement, qnode_prim` so we don't have to touch private functions 2) Adds `qnode` as a keyword argument that gets bound to the qnode primitive 3) Makes it so we can capture a sample measurement specified like `qml.sample(wires=1)` **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** [sc-66703] --------- Co-authored-by: David Wierichs <david.wierichs@xanadu.ai>
Context:
Catalyst PR #837 needs a couple minor updates to the capture module.
Description of the Change:
makes it possible to do
from pennylane.capture import AbstractOperator, AbstractMeasurement, qnode_prim
so we don't have to touch private functionsAdds
qnode
as a keyword argument that gets bound to the qnode primitiveMakes it so we can capture a sample measurement specified like
qml.sample(wires=1)
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-66703]