Raise DeprecationWarning only when the qasm code contains measurements #5904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[sc-66318] |
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.37.0-rc0 #5904 +/- ##
==============================================
Coverage ? 99.66%
==============================================
Files ? 425
Lines ? 40458
Branches ? 0
==============================================
Hits ? 40324
Misses ? 134
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
Interesting branch name! |
lillian542
approved these changes
Jun 28, 2024
dwierichs
requested changes
Jun 28, 2024
There was a problem hiding this comment.
Looks good, thanks @astralcai :) May I ask for a test that no warning is raised for the no-measurements case? And maybe could add the PR number to the existing changelog entry, and a specification of the deprecationwarning being raised to deprecations.rst?
astralcai
commented
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
#5882 led to deprecation warnings raised in non-applicable scenarios
Description of the Change:
Only raise deprecation warning if the circuit contains measurements
Benefits:
Less confusing deprecation warnings