-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legacy device facade class #5927
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5927 +/- ##
==========================================
- Coverage 99.66% 99.65% -0.01%
==========================================
Files 428 429 +1
Lines 41182 41124 -58
==========================================
- Hits 41042 40983 -59
- Misses 140 141 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Next up is figuring out how to keep testing for device switching when DQ.Legacy is gone
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
…LaneAI/pennylane into legacy-device-facade-class
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Context:
We currently have to maintain logic for interacting with two separate device interfaces. This adds extra maintainence, and creates a lot more paths where things can go wrong or get confusing.
Given the number of low-priority plugins that follow the legacy device interface that we probably won't get around to updating, we probably won't be able to get rid of the legacy device interface any time soon. But we can isolate it and limit it's scope.
Description of the Change:
Adds a
LegacyDeviceFacade
class that maps a device from the old device interface to the new device interface.Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-58353]