Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy device facade class #5927

Merged
merged 28 commits into from
Jul 26, 2024
Merged

Legacy device facade class #5927

merged 28 commits into from
Jul 26, 2024

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Jul 2, 2024

Context:

We currently have to maintain logic for interacting with two separate device interfaces. This adds extra maintainence, and creates a lot more paths where things can go wrong or get confusing.

Given the number of low-priority plugins that follow the legacy device interface that we probably won't get around to updating, we probably won't be able to get rid of the legacy device interface any time soon. But we can isolate it and limit it's scope.

Description of the Change:

Adds a LegacyDeviceFacade class that maps a device from the old device interface to the new device interface.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-58353]

Copy link
Contributor

github-actions bot commented Jul 2, 2024

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (b7675ca) to head (42ec3c0).
Report is 299 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5927      +/-   ##
==========================================
- Coverage   99.66%   99.65%   -0.01%     
==========================================
  Files         428      429       +1     
  Lines       41182    41124      -58     
==========================================
- Hits        41042    40983      -59     
- Misses        140      141       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Shiro-Raven Shiro-Raven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Next up is figuring out how to keep testing for device switching when DQ.Legacy is gone

@albi3ro albi3ro requested a review from mudit2812 July 25, 2024 15:21
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
@albi3ro albi3ro enabled auto-merge (squash) July 26, 2024 15:29
@albi3ro albi3ro merged commit 591b351 into master Jul 26, 2024
40 checks passed
@albi3ro albi3ro deleted the legacy-device-facade-class branch July 26, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants