Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate expansion_strategy #5989

Merged
merged 16 commits into from
Jul 19, 2024
Merged

Deprecate expansion_strategy #5989

merged 16 commits into from
Jul 19, 2024

Conversation

Shiro-Raven
Copy link
Contributor

  • expansion_strategy attribute in QNode class deprecated and default value changed to None to avoid raising the deprecation warning by default. Value is reverted back to the old default value "gradient" once the check is carried out.
  • expansion_strategy argument has been deprecated in all of qml.draw, qml.draw_mpl and qml.specs.
  • All instances of using expansion_strategy in qml.draw in the doc examples has been updated to use level instead.

[sc-67221] [sc-67223]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (3fbfe09) to head (4d4c45d).
Report is 286 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5989      +/-   ##
==========================================
+ Coverage   99.59%   99.65%   +0.05%     
==========================================
  Files         427      427              
  Lines       41719    40751     -968     
==========================================
- Hits        41551    40611     -940     
+ Misses        168      140      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/transforms/test_tape_expand.py Show resolved Hide resolved
pennylane/workflow/qnode.py Outdated Show resolved Hide resolved
Shiro-Raven and others added 2 commits July 18, 2024 14:03
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Copy link
Contributor

@PietropaoloFrisoni PietropaoloFrisoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Just some minor observations

doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
Shiro-Raven and others added 2 commits July 18, 2024 16:21
Co-authored-by: Pietropaolo Frisoni <pietropaolo.frisoni@xanadu.ai>
@Shiro-Raven Shiro-Raven enabled auto-merge (squash) July 19, 2024 03:02
@Shiro-Raven Shiro-Raven merged commit 497721a into master Jul 19, 2024
40 checks passed
@Shiro-Raven Shiro-Raven deleted the ad/expansion-strategy-depr branch July 19, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants