-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate expansion_strategy
#5989
Conversation
Hello. You may have forgotten to update the changelog!
|
Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5989 +/- ##
==========================================
+ Coverage 99.59% 99.65% +0.05%
==========================================
Files 427 427
Lines 41719 40751 -968
==========================================
- Hits 41551 40611 -940
+ Misses 168 140 -28 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Just some minor observations
Co-authored-by: Pietropaolo Frisoni <pietropaolo.frisoni@xanadu.ai>
expansion_strategy
attribute inQNode
class deprecated and default value changed toNone
to avoid raising the deprecation warning by default. Value is reverted back to the old default value "gradient" once the check is carried out.expansion_strategy
argument has been deprecated in all ofqml.draw
,qml.draw_mpl
andqml.specs
.expansion_strategy
inqml.draw
in the doc examples has been updated to uselevel
instead.[sc-67221] [sc-67223]