Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating Legacy Devices #5997

Merged
merged 52 commits into from
Jul 24, 2024
Merged

Deprecating Legacy Devices #5997

merged 52 commits into from
Jul 24, 2024

Conversation

Shiro-Raven
Copy link
Contributor

@Shiro-Raven Shiro-Raven commented Jul 13, 2024

Overview of deprecation changes:

  • Added general fixture to conftest.py for capturing warnings. This should capture any uncaptured warnings from the tests (read, the deprecation warnings from the legacy devices), and therefore works as expected and shouldn't cause any issues.
  • Restructured interface tests: moved legacy tests to a separate folder, pulled out tests in the default.qubit folder one level, and added missing tests from the legacy tests to the DQ's tests. This should make the removal process much easier by simply deleting a folder and pulling a bunch of files up a directory.
  • Updated some examples from the pulse module (and related misc. files) that were relying on legacy devices and updated the code block accordingly.
  • Switched from default.qubit.legacy to default.mixed for tests testing the old device interface, and not simply the legacy itself.

[sc-66694]

@Shiro-Raven Shiro-Raven marked this pull request as ready for review July 17, 2024 03:24
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (a456fce) to head (fa8d10a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5997      +/-   ##
==========================================
- Coverage   99.65%   99.65%   -0.01%     
==========================================
  Files         428      428              
  Lines       41160    40883     -277     
==========================================
- Hits        41020    40742     -278     
- Misses        140      141       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Shiro-Raven and others added 2 commits July 18, 2024 23:21
Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
Co-authored-by: Thomas R. Bromley <49409390+trbromley@users.noreply.github.com>
Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Minor non-blocking comment above.

Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
@Shiro-Raven Shiro-Raven requested a review from albi3ro July 23, 2024 15:28
Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me so happy :)

@Shiro-Raven Shiro-Raven enabled auto-merge (squash) July 24, 2024 19:52
@Shiro-Raven Shiro-Raven enabled auto-merge (squash) July 24, 2024 21:09
@Shiro-Raven Shiro-Raven merged commit ad94334 into master Jul 24, 2024
42 checks passed
@Shiro-Raven Shiro-Raven deleted the ad/deprecate-legacy-devices branch July 24, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants