-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to lie_closure #6023
Updates to lie_closure #6023
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6023 +/- ##
==========================================
- Coverage 99.65% 99.65% -0.01%
==========================================
Files 428 428
Lines 41160 40887 -273
==========================================
- Hits 41020 40746 -274
- Misses 140 141 +1 ☔ View full report in Codecov by Sentry. |
[sc-69368] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @Qottmann !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Qottmann!
Fix #6018 and do some other maintenance upgrades
Aim is to allow lie closure to reliably handle cases where sums of paulis are input (e.g. Heisenberg model)
The problem was that sometimes a commutator would be 0 but require a simplify for that to show. Fixed that.