Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to lie_closure #6023

Merged
merged 22 commits into from
Jul 26, 2024
Merged

Updates to lie_closure #6023

merged 22 commits into from
Jul 26, 2024

Conversation

Qottmann
Copy link
Contributor

@Qottmann Qottmann commented Jul 22, 2024

Fix #6018 and do some other maintenance upgrades

Aim is to allow lie closure to reliably handle cases where sums of paulis are input (e.g. Heisenberg model)

The problem was that sometimes a commutator would be 0 but require a simplify for that to show. Fixed that.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (a456fce) to head (8dd7c30).
Report is 301 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6023      +/-   ##
==========================================
- Coverage   99.65%   99.65%   -0.01%     
==========================================
  Files         428      428              
  Lines       41160    40887     -273     
==========================================
- Hits        41020    40746     -274     
- Misses        140      141       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Qottmann Qottmann changed the title [WIP] Updates to lie_closure Updates to lie_closure Jul 23, 2024
@Qottmann Qottmann marked this pull request as ready for review July 23, 2024 12:49
@Qottmann
Copy link
Contributor Author

[sc-69368]

@Qottmann Qottmann requested a review from dwierichs July 23, 2024 15:03
Copy link
Contributor

@dwierichs dwierichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @Qottmann !

pennylane/pauli/dla/lie_closure.py Show resolved Hide resolved
tests/pauli/dla/test_lie_closure.py Show resolved Hide resolved
Copy link
Contributor

@trbromley trbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Qottmann!

pennylane/pauli/dla/lie_closure.py Show resolved Hide resolved
pennylane/pauli/dla/lie_closure.py Show resolved Hide resolved
@Qottmann Qottmann merged commit b7675ca into master Jul 26, 2024
40 checks passed
@Qottmann Qottmann deleted the fixlieclosure branch July 26, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LinAlgError: Singular matrix when trying to do qml.lie_closure on Heisenberg model
3 participants