-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move qml.device
to qml.devices
#6030
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6030 +/- ##
==========================================
- Coverage 99.65% 99.65% -0.01%
==========================================
Files 427 428 +1
Lines 41150 40865 -285
==========================================
- Hits 41010 40724 -286
- Misses 140 141 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Context:
The root
__init__
file is bloated with device instantiation code through theqml.device
function and its helper functions. It is also contaminating the namespace with unrelated third-part packages imports needed for its functionality. The code doesn't need to live in this file since we have a dedicatedqml.devices
module now.Description of the Change:
The relevant code is moved to the
__init__
of theqml.devices
module and reference in the root__init__
file and the docs are adapted. The imports are also pushed inside the relevant functions to avoid contaminating the namespace.Benefits:
More localized functional scopes.
Possible Drawbacks:
None
[sc-65678]