Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate basis state preparation #6116

Merged
merged 33 commits into from
Sep 18, 2024
Merged

Deprecate basis state preparation #6116

merged 33 commits into from
Sep 18, 2024

Conversation

KetpuntoG
Copy link
Contributor

@KetpuntoG KetpuntoG commented Aug 19, 2024 •
edited
Loading

In this PR, BasisStatePreparation is being deprecated

@KetpuntoG KetpuntoG changed the title Deprecate basis state preparation [WIP] Deprecate basis state preparation Aug 19, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.58%. Comparing base (d7db6b4) to head (831b68a).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6116   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files         444      444           
  Lines       42323    42325    +2     
=======================================
+ Hits        42149    42151    +2     
  Misses        174      174

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KetpuntoG KetpuntoG changed the title [WIP] Deprecate basis state preparation Deprecate basis state preparation Aug 20, 2024
@soranjh soranjh added the do not merge ⚠️ Do not merge the pull request until this label is removed label Aug 21, 2024
@KetpuntoG
Copy link
Contributor Author

[sc-72045]

@KetpuntoG KetpuntoG requested a review from soranjh August 26, 2024 19:44
@soranjh soranjh removed the do not merge ⚠️ Do not merge the pull request until this label is removed label Aug 26, 2024
mudit2812
mudit2812 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just suggestions to replace the fixtures you added with pytest.mark.filterwarnings.

doc/development/deprecations.rst Outdated Show resolved Hide resolved
doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
pennylane/devices/tests/test_templates.py Outdated Show resolved Hide resolved
tests/capture/test_templates.py Outdated Show resolved Hide resolved
tests/ops/qubit/test_state_prep.py Outdated Show resolved Hide resolved
tests/transforms/test_batch_input.py Outdated Show resolved Hide resolved
tests/transforms/test_batch_params.py Outdated Show resolved Hide resolved
tests/transforms/test_defer_measurements.py Outdated Show resolved Hide resolved
mudit2812
mudit2812 approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving again! 🎉

@KetpuntoG KetpuntoG enabled auto-merge (squash) September 18, 2024 14:35
@KetpuntoG KetpuntoG merged commit b52af2e into master Sep 18, 2024
37 checks passed
@KetpuntoG KetpuntoG deleted the deprecate-BasisStatePreparation branch September 18, 2024 18:35
mudit2812 added a commit that referenced this pull request Sep 23, 2024
@KetpuntoG @mudit2812
Deprecate basis state preparation (#6116)
1d6b859 
In this PR, BasisStatePreparation is being deprecated

---------

Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
@lillian542 lillian542 mentioned this pull request Nov 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soranjh soranjh soranjh approved these changes

@mudit2812 mudit2812 mudit2812 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KetpuntoG @mudit2812 @soranjh