Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reference.qubit for testing and reference #6181

Merged
merged 80 commits into from
Sep 17, 2024
Merged

Add reference.qubit for testing and reference #6181

merged 80 commits into from
Sep 17, 2024

Conversation

astralcai
Copy link
Contributor

Created from #5445

[sc-65558]

@astralcai astralcai changed the title Add mini.qubit for testing and reference Add reference.qubit for testing and reference Aug 29, 2024
@astralcai astralcai marked this pull request as ready for review August 30, 2024 14:47
@astralcai astralcai marked this pull request as draft August 30, 2024 14:47
@astralcai astralcai marked this pull request as ready for review August 30, 2024 15:01
@astralcai astralcai marked this pull request as draft August 30, 2024 15:01
@astralcai astralcai closed this Sep 3, 2024
@astralcai astralcai reopened this Sep 3, 2024
@astralcai astralcai marked this pull request as ready for review September 4, 2024 14:51
@codecov Codecov
Copy link

codecov bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.58%. Comparing base (b78565c) to head (d7d9861).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6181   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files         443      444    +1     
  Lines       42273    42333   +60     
=======================================
+ Hits        42096    42156   +60     
  Misses        177      177

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astralcai astralcai marked this pull request as draft September 5, 2024 18:37
@astralcai astralcai marked this pull request as ready for review September 5, 2024 18:55
@astralcai astralcai changed the base branch from master to autograd-bug September 12, 2024 18:25
@astralcai astralcai changed the title [WIP] Add reference.qubit for testing and reference Add reference.qubit for testing and reference Sep 13, 2024
@astralcai @albi3ro
Update pennylane/devices/reference_qubit.py
5b6427f 
Co-authored-by: Christina Lee <christina@xanadu.ai>
albi3ro
albi3ro reviewed Sep 13, 2024
View reviewed changes
Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would you think about adding some assertions inside execute to make sure we are passing in suitably supported tapes? For example:

assert tape.batch
assert all(supports_operation(op) for op in tape.operations)

Not mandatory, but might be useful.

@astralcai @albi3ro
Update pennylane/devices/reference_qubit.py
52caafc 
Co-authored-by: Christina Lee <christina@xanadu.ai>
albi3ro
albi3ro approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Base automatically changed from autograd-bug to master September 16, 2024 13:57
lillian542
lillian542 reviewed Sep 16, 2024
View reviewed changes
Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be added to the devices so it turns up in the documentation here?

pennylane/devices/reference_qubit.py Outdated Show resolved Hide resolved
astralcai and others added 2 commits September 16, 2024 16:42
@astralcai @lillian542
Update pennylane/devices/reference_qubit.py
bf4b212 
Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com>
@astralcai
add ReferenceQubit to devices
449a0cd
lillian542
lillian542 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @astralcai! 🚀

@astralcai astralcai enabled auto-merge (squash) September 17, 2024 13:33
@astralcai astralcai merged commit 805d4cf into master Sep 17, 2024
37 checks passed
@astralcai astralcai deleted the mini-dev-new branch September 17, 2024 13:58
mudit2812 pushed a commit that referenced this pull request Sep 18, 2024
@astralcai @dwierichs
@albi3ro @lillian542 @mudit2812
Add reference.qubit for testing and reference (#6181)
adb9ab6 
Created from #5445

[sc-65558]

---------

Co-authored-by: dwierichs <david.wierichs@xanadu.ai>
Co-authored-by: Christina Lee <christina@xanadu.ai>
Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albi3ro albi3ro albi3ro approved these changes

@lillian542 lillian542 lillian542 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@astralcai @albi3ro @lillian542 @dwierichs