Add emery and Haldane model Hamiltonians #6201

ddhawan11 · 2024-09-03T19:02:11Z

Context:
Add functions to generate emery and Haldane model Hamiltonians on a lattice.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-71958]

pennylane/spin/spin_hamiltonian.py

github-actions · 2024-09-04T11:10:31Z

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

A one-to-two sentence description of the change. You may include a small working example for new features.
A link back to this PR.
Your name (or GitHub username) in the contributors section.

codecov · 2024-09-04T11:49:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.70%. Comparing base (de54c54) to head (e52a5e2).
Report is 4 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6201   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files         444      444           
  Lines       42133    42192   +59     
=======================================
+ Hits        42008    42069   +61     
+ Misses        125      123    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

austingmhuang

Looking good @ddhawan11, left some initial comments.

doc/releases/changelog-dev.md

pennylane/spin/spin_hamiltonian.py

Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>

pennylane/spin/spin_hamiltonian.py

austingmhuang

Looking good @ddhawan11. Left some nitpicky things. I think there can be a decent amount of refactoring but I'll take a deeper look again later.

doc/releases/changelog-dev.md

pennylane/spin/spin_hamiltonian.py

tests/spin/test_spin_hamiltonian.py

pennylane/spin/spin_hamiltonian.py

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>

soranjh

Thanks @ddhawan11, looks good overall. Left some high-level comments for now.

pennylane/spin/spin_hamiltonian.py

tests/spin/test_spin_hamiltonian.py

pennylane/spin/spin_hamiltonian.py

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

soranjh

Thanks @ddhawan11, left my final set of comments.

pennylane/spin/spin_hamiltonian.py

tests/spin/test_spin_hamiltonian.py

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

soranjh

Thanks @ddhawan11, left two very minor comments. Good to merge after resolving them, but please check the docs before merging.

pennylane/spin/spin_hamiltonian.py

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

**Context:** Add functions to generate emery and Haldane model Hamiltonians on a lattice. **Description of the Change:** **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** [sc-71958] --------- Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com> Co-authored-by: Utkarsh <utkarshazad98@gmail.com> Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

Added emery and Haldane models

615cab3

ddhawan11 requested review from obliviateandsurrender and austingmhuang September 3, 2024 19:03

obliviateandsurrender requested changes Sep 3, 2024

View reviewed changes

ddhawan11 added 2 commits September 4, 2024 13:54

Merge branch 'master' into emery_haldane_models

9427e3a

Merge branch 'master' into emery_haldane_models

3582117

ddhawan11 marked this pull request as ready for review September 4, 2024 11:10

ddhawan11 added 2 commits September 4, 2024 08:33

Addressed comments

979ea79

Fixed whitespace

0045c66

ddhawan11 requested a review from obliviateandsurrender September 4, 2024 13:18

austingmhuang reviewed Sep 4, 2024

View reviewed changes

ddhawan11 and others added 11 commits September 5, 2024 04:18

Update doc/releases/changelog-dev.md

e0a05e2

Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>

Update pennylane/spin/spin_hamiltonian.py

0778ced

Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>

Update pennylane/spin/spin_hamiltonian.py

380b24c

Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>

Update pennylane/spin/spin_hamiltonian.py

684969f

Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>

Update pennylane/spin/spin_hamiltonian.py

0ec54e8

Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>

Update pennylane/spin/spin_hamiltonian.py

88620ef

Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>

Update pennylane/spin/spin_hamiltonian.py

9562357

Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>

Update pennylane/spin/spin_hamiltonian.py

6b54633

Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>

Update pennylane/spin/spin_hamiltonian.py

dd139ca

Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>

Addressed comments and increased test coverage

d3f86de

Merge branch 'master' into emery_haldane_models

5ab0f33

ddhawan11 requested a review from austingmhuang September 5, 2024 12:43

[skip ci] docstring fix

5108a0f

obliviateandsurrender reviewed Sep 5, 2024

View reviewed changes

austingmhuang requested changes Sep 5, 2024

View reviewed changes

ddhawan11 and others added 2 commits September 6, 2024 05:06

Update pennylane/spin/spin_hamiltonian.py

9c8a613

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

Update pennylane/spin/spin_hamiltonian.py

04af095

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

ddhawan11 and others added 3 commits September 9, 2024 10:50

Update pennylane/spin/spin_hamiltonian.py

9fbba47

Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>

Update pennylane/spin/spin_hamiltonian.py

63d9c46

Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>

Merge branch 'master' into emery_haldane_models

d6be8a8

ddhawan11 requested a review from soranjh September 10, 2024 16:41

soranjh requested changes Sep 13, 2024

View reviewed changes

ddhawan11 and others added 3 commits September 16, 2024 11:20

Addressed reviews

425fbbe

Merge branch 'master' into emery_haldane_models

de09ac0

Updated change-log

cd7cc49

ddhawan11 requested a review from soranjh September 16, 2024 15:27

soranjh reviewed Sep 16, 2024

View reviewed changes

tests/spin/test_spin_hamiltonian.py Outdated Show resolved Hide resolved

Changed test

8c9b17f

ddhawan11 requested a review from soranjh September 16, 2024 17:12

obliviateandsurrender reviewed Sep 17, 2024

View reviewed changes

pennylane/spin/spin_hamiltonian.py Outdated Show resolved Hide resolved

ddhawan11 and others added 2 commits September 18, 2024 10:55

Update pennylane/spin/spin_hamiltonian.py

62b9ffd

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

Merge branch 'master' into emery_haldane_models

51e82c0

soranjh requested changes Sep 19, 2024

View reviewed changes

ddhawan11 and others added 4 commits September 20, 2024 06:03

Update pennylane/spin/spin_hamiltonian.py

9d06dde

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

Update pennylane/spin/spin_hamiltonian.py

f7512ab

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

Update pennylane/spin/spin_hamiltonian.py

f20aaf5

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

Addressed reviews

7525569

ddhawan11 requested a review from soranjh September 20, 2024 13:56

soranjh approved these changes Sep 20, 2024

View reviewed changes

pennylane/spin/spin_hamiltonian.py Outdated Show resolved Hide resolved

pennylane/spin/spin_hamiltonian.py Outdated Show resolved Hide resolved

ddhawan11 and others added 3 commits September 20, 2024 10:22

Update pennylane/spin/spin_hamiltonian.py

f86a1fe

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

Update pennylane/spin/spin_hamiltonian.py

306f0e3

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

Merge branch 'master' into emery_haldane_models

953f5d6

ddhawan11 enabled auto-merge (squash) September 20, 2024 14:27

Fixed black

e52a5e2

ddhawan11 merged commit a1ccaeb into master Sep 20, 2024
37 checks passed

ddhawan11 deleted the emery_haldane_models branch September 20, 2024 15:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add emery and Haldane model Hamiltonians #6201

Add emery and Haldane model Hamiltonians #6201

ddhawan11 commented Sep 3, 2024

github-actions bot commented Sep 4, 2024

codecov bot commented Sep 4, 2024 •

edited

Loading

austingmhuang left a comment

austingmhuang left a comment

soranjh left a comment

soranjh left a comment

soranjh left a comment

Add emery and Haldane model Hamiltonians #6201

Add emery and Haldane model Hamiltonians #6201

Conversation

ddhawan11 commented Sep 3, 2024

github-actions bot commented Sep 4, 2024

codecov bot commented Sep 4, 2024 • edited Loading

Codecov Report

austingmhuang left a comment

Choose a reason for hiding this comment

austingmhuang left a comment

Choose a reason for hiding this comment

soranjh left a comment

Choose a reason for hiding this comment

soranjh left a comment

Choose a reason for hiding this comment

soranjh left a comment

Choose a reason for hiding this comment

codecov bot commented Sep 4, 2024 •

edited

Loading