Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove decomp_depth from qml.device constructor #6234

Merged
merged 17 commits into from
Sep 17, 2024
Merged

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Sep 6, 2024

The decomp_depth keyword argument only served to prevent operations from being fully decomposed to the target gateset. It is now removed.

[sc-72706]

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.59%. Comparing base (b78565c) to head (d03c728).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6234      +/-   ##
==========================================
+ Coverage   99.58%   99.59%   +0.01%     
==========================================
  Files         443      444       +1     
  Lines       42273    42336      +63     
==========================================
+ Hits        42096    42163      +67     
+ Misses        177      173       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change needed for rendering docs correctly, otherwise looks good.

@mudit2812 mudit2812 enabled auto-merge (squash) September 17, 2024 19:56
@mudit2812 mudit2812 merged commit 2d8cd54 into master Sep 17, 2024
37 checks passed
@mudit2812 mudit2812 deleted the remove-decomp-depth branch September 17, 2024 20:42
mudit2812 added a commit that referenced this pull request Sep 18, 2024
The `decomp_depth` keyword argument only served to prevent operations
from being fully decomposed to the target gateset. It is now removed.


[sc-72706]

---------

Co-authored-by: Astral Cai <astral.cai@xanadu.ai>
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
mudit2812 added a commit that referenced this pull request Sep 23, 2024
The `decomp_depth` keyword argument only served to prevent operations
from being fully decomposed to the target gateset. It is now removed.


[sc-72706]

---------

Co-authored-by: Astral Cai <astral.cai@xanadu.ai>
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
@lillian542 lillian542 mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants