Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some end-to-end default_qubit_native_mcm tests #6246

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

obliviateandsurrender
Copy link
Contributor

Context: Remove most end-to-end tests from test_default_qubit_native_mcm.py

Description of the Change: Combined some of the tests to remove code redundancy, shifted one of them to simulate_tree_mcm and mostly kept the interface end-to-end tests.

Benefits: Removes redundant end-to-end test.

Possible Drawbacks:

Related GitHub Issues: [sc-72204]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.58%. Comparing base (68fd307) to head (81338eb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6246      +/-   ##
==========================================
- Coverage   99.59%   99.58%   -0.01%     
==========================================
  Files         444      444              
  Lines       42323    42323              
==========================================
- Hits        42150    42149       -1     
- Misses        173      174       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@astralcai astralcai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is no coverage missing from removing those tests so that's a good sign.

@obliviateandsurrender obliviateandsurrender merged commit d7db6b4 into master Sep 18, 2024
37 checks passed
@obliviateandsurrender obliviateandsurrender deleted the remove-mcm-end-to-end-tests branch September 18, 2024 15:55
mudit2812 pushed a commit that referenced this pull request Sep 23, 2024
**Context:** Remove most end-to-end tests from
`test_default_qubit_native_mcm.py`

**Description of the Change:** Combined some of the tests to remove code
redundancy, shifted one of them to `simulate_tree_mcm` and mostly kept
the interface end-to-end tests.

**Benefits:** Removes redundant end-to-end test.

**Possible Drawbacks:**

**Related GitHub Issues:** [sc-72204]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants