PennyLane is compatible with JAX 0.4.28 #6255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aN to np.nan" This reverts commit b3ab335. Reverting changes from numpy formating and NAN
revert changes from numpy printing settings
attempt to use the legacy printing option
…o compatible-np-2.0
…nd suggestion from code reviw
…o compatible-np-2.0
…o compatible-np-2.0
…2-install set to true
…o compatible-np-2.0
…o compatible-np-2.0
…ion/test_optimization_utils.py`
… is already in `setup.py`
…o compatible-np-2.0
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6255 +/- ##
==========================================
- Coverage 99.58% 99.57% -0.01%
==========================================
Files 443 444 +1
Lines 42273 42336 +63
==========================================
+ Hits 42096 42158 +62
- Misses 177 178 +1 ☔ View full report in Codecov by Sentry. |
dwierichs
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
LGTM, thanks @PietropaoloFrisoni 🎉
Just wanted to ask about documenting the change and potentially adapting requirements files to the new supported JAX version?
mudit2812
pushed a commit
that referenced
this pull request
Sep 18, 2024
**Context:** As part of the effort to make PL compatible with Numpy 2.0 (see #6061), we need to upgrade JAX to 0.4.26+ since such a version introduced the support for Numpy 2.0. We opted for JAX 0.4.28 since it is the same version used by Catalyst. **Description of the Change:** As above. **Benefits:** PL is compatible with Numpy 2.0 and Jax 0.4.28. **Possible Drawbacks:** - From JAX 0.4.27, in `jax.jit`, passing invalid static_argnums or static_argnames now leads to an error rather than a warning. In PL, this breaks every test where we set `shots` in the `QNode` call with `static_argnames=["shots"]`. At this stage, we decided to mark such tests with `pytest.xfail` to allow the upgrade. **Related GitHub Issues:** None. **Related Shortcut Stories**: [sc-61389] --------- Co-authored-by: dwierichs <david.wierichs@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: As part of the effort to make PL compatible with Numpy 2.0 (see #6061), we need to upgrade JAX to 0.4.26+ since such a version introduced the support for Numpy 2.0. We opted for JAX 0.4.28 since it is the same version used by Catalyst.
Description of the Change: As above.
Benefits: PL is compatible with Numpy 2.0 and Jax 0.4.28.
Possible Drawbacks:
jax.jit, passing invalid static_argnums or static_argnames now leads to an error rather than a warning. In PL, this breaks every test where we setshotsin theQNodecall withstatic_argnames=["shots"]. At this stage, we decided to mark such tests withpytest.xfailto allow the upgrade.Related GitHub Issues: None.
Related Shortcut Stories: [sc-61389]