Updating torch to 2.3.0 #6258
Merged
Updating torch to 2.3.0 #6258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aN to np.nan" This reverts commit b3ab335. Reverting changes from numpy formating and NAN
revert changes from numpy printing settings
attempt to use the legacy printing option
…o compatible-np-2.0
…nd suggestion from code reviw
…o compatible-np-2.0
…o compatible-np-2.0
…2-install set to true
…o compatible-np-2.0
…o compatible-np-2.0
…y planned because of this typo)
…o compatible-np-2.0
…rately in the workflow matrix)
…o compatible-np-2.0
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6258 +/- ##
==========================================
- Coverage 99.59% 99.58% -0.01%
==========================================
Files 443 443
Lines 42255 42273 +18
==========================================
+ Hits 42082 42096 +14
- Misses 173 177 +4 ☔ View full report in Codecov by Sentry. |
mudit2812
approved these changes
Sep 16, 2024
…o update_torch
mudit2812
pushed a commit
that referenced
this pull request
Sep 16, 2024
**Context:** We want to make PL compatible with torch 2.3.0 (including GPU tests) after updating Numpy from 1.x to 2.x. **Description of the Change:** As above. **Benefits:** We are sure that PL is compatible with torch 2.3.0. **Possible Drawbacks:** None that I can think of right now. **Related GitHub Issues:** None. **Related Shortcut Stories:** [sc-61391]
mudit2812
pushed a commit
that referenced
this pull request
Sep 16, 2024
**Context:** We want to make PL compatible with torch 2.3.0 (including GPU tests) after updating Numpy from 1.x to 2.x. **Description of the Change:** As above. **Benefits:** We are sure that PL is compatible with torch 2.3.0. **Possible Drawbacks:** None that I can think of right now. **Related GitHub Issues:** None. **Related Shortcut Stories:** [sc-61391]
mudit2812
pushed a commit
that referenced
this pull request
Sep 18, 2024
**Context:** We want to make PL compatible with torch 2.3.0 (including GPU tests) after updating Numpy from 1.x to 2.x. **Description of the Change:** As above. **Benefits:** We are sure that PL is compatible with torch 2.3.0. **Possible Drawbacks:** None that I can think of right now. **Related GitHub Issues:** None. **Related Shortcut Stories:** [sc-61391]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: We want to make PL compatible with torch 2.3.0 (including GPU tests) after updating Numpy from 1.x to 2.x.
Description of the Change: As above.
Benefits: We are sure that PL is compatible with torch 2.3.0.
Possible Drawbacks: None that I can think of right now.
Related GitHub Issues: None.
Related Shortcut Stories: [sc-61391]