Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test in legacy opmath #6272

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Fix failing test in legacy opmath #6272

merged 2 commits into from
Sep 13, 2024

Conversation

astralcai
Copy link
Contributor

A follow up of #6252, does the same but with a different test.

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@astralcai astralcai enabled auto-merge (squash) September 13, 2024 20:04
@astralcai astralcai merged commit 1cbaeec into master Sep 13, 2024
36 checks passed
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.59%. Comparing base (060bb9a) to head (9e09e84).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6272   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files         444      444           
  Lines       42321    42321           
=======================================
  Hits        42149    42149           
  Misses        172      172           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astralcai astralcai deleted the legacy-test-fix branch September 13, 2024 20:20
mudit2812 pushed a commit that referenced this pull request Sep 16, 2024
A follow up of #6252, does
the same but with a different test.
mudit2812 pushed a commit that referenced this pull request Sep 16, 2024
A follow up of #6252, does
the same but with a different test.
mudit2812 pushed a commit that referenced this pull request Sep 18, 2024
A follow up of #6252, does
the same but with a different test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants