-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to benchmark pull requests #6274
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6274 +/- ##
=======================================
Coverage 99.70% 99.70%
=======================================
Files 444 444
Lines 42226 42226
=======================================
Hits 42103 42103
Misses 123 123 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks Rashid!
I think there is some future work on the benchmark side to cleanly format the output reported back to the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but is it possible to try it out before we merge? Just want to see it in action to verify it works. The code itself looks fine to me, but I also don't use javascript much. Or is it not possible since the PR on the benchmarks suite-side is still open?
I have tried to get the code to work as much as I could in a private fork ... however, yes, none of the changes here can be tested as part PR unfortunately |
All good then. This is all pretty early iteration work anyway, we can always come back later with bug fixes 😄 |
Context: Add ability to benchmark a pull request
Description of the Change:
This pull request adds the ability to benchmark a PR.
When a user with either
admin
ormaintain
permissions comments/benchmark
on a pull request, this workflow will trigger a webhook to benchmarks repo with sufficient details to benchmark the PR, it is then up to the benchmarks action to report back with results.Once the webhook is sent, a 👍 reaction is added to the comment to indicate it was successful.
Benefits:
New feature.
Possible Drawbacks:
This is an MVP product, we may want to iterate on this to add further information or functionality. However, the current state is sufficient for the basic needs of benchmarking.
Related GitHub Issues:
None. sc-73314