Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove simplify argument from Hamiltonian and LinearCombination #6279

Merged
merged 7 commits into from
Sep 18, 2024
Merged

Remove simplify argument from Hamiltonian and LinearCombination #6279

merged 7 commits into from
Sep 18, 2024

Conversation

mudit2812
Copy link
Contributor

As name says. [sc-72003]

@mudit2812 mudit2812 marked this pull request as ready for review September 17, 2024 20:31
@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.59%. Comparing base (2d8cd54) to head (214a75f).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6279      +/-   ##
==========================================
- Coverage   99.59%   99.59%   -0.01%     
==========================================
  Files         444      444              
  Lines       42336    42323      -13     
==========================================
- Hits        42163    42150      -13     
  Misses        173      173

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

PietropaoloFrisoni
PietropaoloFrisoni approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@PietropaoloFrisoni PietropaoloFrisoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

dwierichs
dwierichs approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@dwierichs dwierichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a mention of simplify upon initialization in doc/news/new_opmath.rst. I'm not entirely sure but it might be good to remove it from there? 🤔
Otherwise LGTM! 🎉

@mudit2812
Copy link
Contributor Author

mudit2812 commented Sep 18, 2024 •
edited
Loading

@dwierichs Thanks for catching that. I've fixed it now.

@mudit2812 mudit2812 enabled auto-merge (squash) September 18, 2024 14:00
@mudit2812 mudit2812 merged commit 68fd307 into master Sep 18, 2024
36 checks passed
@mudit2812 mudit2812 deleted the remove-simplify branch September 18, 2024 14:01
mudit2812 added a commit that referenced this pull request Sep 18, 2024
@mudit2812
Remove simplify argument from Hamiltonian and LinearCombination (…
fc80d56 
…#6279)

As name says. [sc-72003]
mudit2812 added a commit that referenced this pull request Sep 23, 2024
@mudit2812
Remove simplify argument from Hamiltonian and LinearCombination (…
3b2f5cb 
…#6279)

As name says. [sc-72003]
@lillian542 lillian542 mentioned this pull request Nov 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PietropaoloFrisoni PietropaoloFrisoni PietropaoloFrisoni approved these changes

@dwierichs dwierichs dwierichs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mudit2812 @dwierichs @PietropaoloFrisoni