Add generator checks and differentiability checks to assert_valid #6282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
astralcai
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6282 +/- ##
=======================================
Coverage 99.39% 99.40%
=======================================
Files 446 446
Lines 42328 42358 +30
=======================================
+ Hits 42073 42104 +31
+ Misses 255 254 -1 ☔ View full report in Codecov by Sentry. |
albi3ro
reviewed
Sep 23, 2024
1 task
…o assert-valid
1 task
astralcai
changed the title
albi3ro
reviewed
Oct 3, 2024
albi3ro
reviewed
Oct 3, 2024
albi3ro
approved these changes
Oct 3, 2024
1 task
austingmhuang
pushed a commit
that referenced
this pull request
Oct 23, 2024
) The purpose of this story is to check if every operator can be differentiated properly with the parameter shift method. The gradient calculated using parameter shift is compared with backprop to verify that they are equal. There are some cases where this does not apply: 1. Backprop does not produce the correct gradient in some cases such as for `StatePrep` and for `QubitUnitary`, as it does not take into account the constraint that the matrix must remain unitary, making this test invalid. 2. Some operator takes integers as parameters, such as `BasisState`. In this case, it does not make sense to take the gradient of integer parameters. For these cases, a `skip_differentiation` toggle is added to `assert_valid` such that the differentiation check is skipped for these operators. Three bugs are found as a result of adding this check. The relevant tests are xfailed: #6331 #6333 #6340 Some other minor bug fixes are also included in this PR. [sc-65197] Fixes #6311
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this story is to check if every operator can be differentiated properly with the parameter shift method. The gradient calculated using parameter shift is compared with backprop to verify that they are equal.
There are some cases where this does not apply:
StatePrepand forQubitUnitary, as it does not take into account the constraint that the matrix must remain unitary, making this test invalid.BasisState. In this case, it does not make sense to take the gradient of integer parameters.For these cases, a
skip_differentiationtoggle is added toassert_validsuch that the differentiation check is skipped for these operators.Three bugs are found as a result of adding this check. The relevant tests are xfailed:
#6331
#6333
#6340
Some other minor bug fixes are also included in this PR.
[sc-65197]
Fixes #6311