Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure in legacy opmath #6310

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Fix failure in legacy opmath #6310

merged 3 commits into from
Sep 30, 2024

Conversation

astralcai
Copy link
Contributor

A follow up PR to #6278, fixes recent failure in legacy opmath.

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link
Contributor

@dwierichs dwierichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
Do we track bugfixes for legacy op math in the changelog? :)

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.70%. Comparing base (be676fe) to head (7589d72).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6310   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files         444      444           
  Lines       42223    42226    +3     
=======================================
+ Hits        42100    42103    +3     
  Misses        123      123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astralcai
Copy link
Contributor Author

LGTM 🎉 Do we track bugfixes for legacy op math in the changelog? :)

I'll update the changelog.

@astralcai astralcai merged commit b997e0f into master Sep 30, 2024
37 checks passed
@astralcai astralcai deleted the fix-legacy branch September 30, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants